[PATCH 0 of 1 STABLE RFC] Remove os.path.realpath workaround for darwin

Augie Fackler durin42 at gmail.com
Tue Nov 1 09:44:30 CDT 2011


On Oct 31, 2011, at 7:34 PM, Christian Ebert wrote:

> * Augie Fackler on Monday, October 31, 2011 at 19:14:38 -0500
>> On Oct 30, 2011, at 10:43 AM, Matt Mackall wrote:
>>> On Sun, 2011-10-30 at 14:18 +0100, Christian Ebert wrote:
>>>>> This one should be reverted then:
>>>>> http://www.selenic.com/hg/rev/dbdb777502dc
>>>> 
>>>> Right, I see that dbdb777502dc is backed out now, so, yes, then
>>>> 42630f54e513 should be backed out too.
>>> 
>>> Ok, a backout is queued.
>> 
>> What should I back out in a local client to run tests?
> 
> 42630f54e513 and dbdb777502dc - but they are already backed out
> in stable.
> 
>> I'm suspicious that this will break OS X > 10.5, and will
>> gladly run tests tonight if I know what I should test.
> 
> I strongly believe Dan's workaround for os.path.realpath from
> 2009
> http://selenic.com/repo/hg/rev/40196d036a71
> concerns < 10.5 - but, yes, testing would be very good.
> But you would probably have noticed before. The problem only came
> up when os.path.realpath was actually replaced with
> util.realpath.
> 
> My hypothesis is that testing on MacOS < 10.5 and probably Python
> 2.4 will break (the reason for Dan's workaround) - but we'll see
> ;-)

No unexpected failures (lfconvert failed, as well as an https proxy test that has never worked for me without usehttp2 enabled) here with the stock system Python on 10.6.

> 
> c
> -- 
> theatre - books - texts - movies
> Black Trash Productions at home: http://www.blacktrash.org
> Black Trash Productions on Facebook:
> http://www.facebook.com/blacktrashproductions



More information about the Mercurial-devel mailing list