[PATCH 3 of 3] add: deprecate --subrepo option

David M. Carr david at carrclan.us
Tue Nov 1 13:36:26 CDT 2011


On Tuesday, November 1, 2011, Matt Mackall <mpm at selenic.com> wrote:
> On Mon, 2011-10-31 at 21:56 -0400, David M. Carr wrote:
>> # HG changeset patch
>> # User David M. Carr  <david at carrclan.us>
>> # Date 1320030277 14400
>> # Branch stable
>> # Node ID 8d239d0d31bf8a5b8f1f8aa0a89f64a491ed4e41
>> # Parent  5e4b658f6f60adff3cc39ef20ea2753ca9a29db5
>> add: deprecate --subrepo option
>>
>> Now that handling subrepos in add is always done, there's no point in
>> using an option that will always be ignored.  For now, retain it for
>> backwards compatibility.
>
> Seems like something is wrong here, then.
>
> The current state of affairs is:
>
>  $ hg add
>  adding notinsubrepo
>  $ hg add sub/foo # explicit subrepo add -> silent failure
>  $ hg add -S
>  add sub/foo
>  add sub/bar
>
> We want this to change to:
>
>  $ hg add
>  adding notinsubrepo
>  $ hg add sub/foo # silent success
>  $ hg add -S
>  adding sub/bar
>
> But it sounds like you've changed it to:
>
>  $ hg add
>  adding notinsubrepo
>  adding sub/foo
>  adding sub/bar
>
>
> (This is all the review I have time for right now, please resend your
> patches after the 2.0 release.)
>
> --
> Mathematics is the supreme nostalgia of our time.
>
>
>

Thanks for the review. I'll verify whether this is indeed the case.

-- 
David M. Carr
david at carrclan.us
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20111101/38fc778e/attachment.html>


More information about the Mercurial-devel mailing list