[PATCH] Remove unused code in pure/mpatch.py

Martin Geisler mg at aragost.com
Mon Nov 7 05:17:53 CST 2011


Mads Kiilerich <mads at kiilerich.com> writes:

> On 11/07/2011 10:44 AM, Andrey wrote:
>> Subject: 	Re: [PATCH] Remove unused code in pure/mpatch.py
>> Date: 	Mon, 7 Nov 2011 01:44:49 -0800 (PST)
>> From: 	Andrey <py4fun at gmail.com>
>> Reply-To: 	mercurial_devel at googlegroups.com
>> To: 	mercurial_devel at googlegroups.com
>
> Please don't use that stupid mirror. It adds confusion and breaks the
> mail workflow of other users on the list.

I'm curious what the problem is? As far as I can see, the mail has a
correct In-Reply-To header and was threaded correctly here. Going up
twice in the thread brings me to the original patch so I don't see
anything broken here.

>> CC: 	mercurial-devel at selenic.com
>>
>>
>>
>> The second attempt (after November 1)
>>
>> (The patch does not change the functionality.)
>
> Please send a new patchbomb.

I just looked at the patch and it seems to me that the early return is
there to make the code clearer. Instead of proceeding and doing a whole
lot of nothing (writing some empty strings into a buffer?) then we exit
early if we can.

-- 
Martin Geisler

aragost Trifork
Professional Mercurial support
http://mercurial.aragost.com/kick-start/


More information about the Mercurial-devel mailing list