AW: [PATCH 4 of 7] setup: hgbuildmo inherits from Command

Sabina und Simon Heimberg s.heimberg at bluewin.ch
Fri Nov 11 17:46:04 CST 2011


> Mads Kiilerich wrote, On 9.11.2011 00:01
> 
> Simon Heimberg wrote, On 11/08/2011 11:36 PM:
> > # HG changeset patch
> > # User Simon Heimberg<simohe at besonet.ch> # Date 1320174833 -3600 #
> > Node ID 287a7c88281cbe54abb385305ba188afdaa8e1fe
> > # Parent  9fc70a870523c5fb877ab7bd265d5ff915dda9ab
> > setup: hgbuildmo inherits from Command
> 
> Why?

Because hgbuildmo is a command and has nothing to do with build, which is
the entire build process. We do not need its options, its subcommands nor its has_* methods.


> 
> > diff -r 9fc70a870523 -r 287a7c88281c setup.py
> > --- a/setup.py	Die Nov 01 20:13:53 2011 +0100
> > +++ b/setup.py	Die Nov 01 20:13:53 2011 +0100
> > @@ -192,7 +192,7 @@

snip

(This time the answer goes on list too. Sorry Mads for the extra
traffic.)


More information about the Mercurial-devel mailing list