[PATCH 3 of 3] tests: run check-code with warnings and maintain a whitelist

Martin Geisler mg at lazybytes.net
Sat Nov 12 09:19:59 CST 2011


Mads Kiilerich <mads at kiilerich.com> writes:

> # HG changeset patch
> # User Mads Kiilerich <mads at kiilerich.com>
> # Date 1320971660 -3600
> # Node ID 0598b000d4669385e216ab98f39dde6aa22e88e1
> # Parent  a67c7da6f7d062d5b8e6840c4c13a517b1f0bdcd
> tests: run check-code with warnings and maintain a whitelist
>
> check-code had fine warning checks, but they are noisy and nobody used them.
>
> Now the warnings will be run in the test suite, where a list of
> accepted warnings will be maitained.
>
> Those who introduce or touch a line with a warning will now have to
> update the whitelist ... or fix the warning.

This is a good idea.

> diff --git a/tests/test-check-code-hg.py.out b/tests/test-check-code-hg.py.out
> new file mode 100644
> --- /dev/null
> +++ b/tests/test-check-code-hg.py.out
> @@ -0,0 +1,656 @@
> +errors:
> +warnings (without line numbers):
> +/home/mk/hg/contrib/check-code.py:0:

But the absolute path names here will cause problems.


-- 
Martin Geisler

Mercurial links: http://mercurial.ch/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20111112/9f22a0f3/attachment.pgp>


More information about the Mercurial-devel mailing list