[issue3128] Call file merge util through mercurial.ui.ui

Kirill Gagarski bugs at mercurial.selenic.com
Fri Nov 25 18:20:32 CST 2011


New submission from Kirill Gagarski <gagarin.gtn at gmail.com>:

When I am doing "hg commit" the editor for commit message is called through
mercurial.ui.ui.edit() method. It's good because if i want to change
behaviour of editor i can inherit the mercurial.ui.ui class, override the
edit() method and pass instance of my class to mercurial.dispatch.dispatch().

I hoped that I can do the same with calling the manual merge utility (vim
with 3 tabs by default). And I was surprised that I can't. Instead of this
merge program is called in filemerge.py. So if I want to change the
behaviour of "merge" command I need to override much more than one method.

Is there any objective reasons for such structure? Maybe better to call the
merge program through something like ui.ui.manual_merge()?

----------
messages: 18166
nosy: gtn_gagarin
priority: wish
status: unread
title: Call file merge util through mercurial.ui.ui

____________________________________________________
Mercurial issue tracker <bugs at mercurial.selenic.com>
<http://mercurial.selenic.com/bts/issue3128>
____________________________________________________


More information about the Mercurial-devel mailing list