[PATCH] revert: add support for reverting subrepos

Greg Ward greg-hg at gerg.ca
Tue Oct 4 20:05:32 CDT 2011


On Tue, Oct 4, 2011 at 11:58 AM, Angel Ezquerra
<angel.ezquerra at gmail.com> wrote:
> # HG changeset patch
> # User Angel Ezquerra <angel.ezquerra at gmail.com>
> # Date 1317712886 -7200
> # Node ID 52bdfa484615d27cf82d537f7f09414c7a058c8c
> # Parent  6dc67dced8c122f6139ae20ccdc03a6b11e8b765
> revert: add support for reverting subrepos

I found this patch very hard to read, and I think it's simply because
you indented/unindented huge blocks of code by adding
if/else/try/while/etc
around them. Perhaps it would be easier to review if you factored out some
worker functions first? Or maybe get most of revert() out of
commands.py -- it's pretty big already, and you're making it bigger.
I'm not sure where it should
go; hg.py seems reasonable given that that's where update and merge live,
but there's already something called revert() in hg.py. Hmmmm.

Greg


More information about the Mercurial-devel mailing list