[PATCH 2 of 4] largefiles: fix commit of specified file on non-windows

[Na'Tosha Bard]

2011/10/5 Matt Mackall <mpm at selenic.com>

> On Wed, 2011-10-05 at 19:35 +0200, Na'Tosha Bard wrote:
> > 2011/10/5 Adrian Buehlmann <adrian at cadifra.com>
> >
> > > On 2011-10-05 18:31, Na'Tosha Bard wrote:
> > > > # HG changeset patch
> > > > # User Na'Tosha Bard <natosha at unity3d.com>
> > > > # Date 1317830968 -7200
> > > > # Node ID 457253b356295ac675dee7131f60eddd7631e36a
> > > > # Parent  098d34125c905d264029c80b962d3f3d96f079e0
> > > > largefiles: fix commit of specified file on non-windows
> > > >
> > > > diff -r 098d34125c90 -r 457253b35629 hgext/largefiles/lfutil.py
> > > > --- a/hgext/largefiles/lfutil.py      Wed Oct 05 17:51:49 2011 +0200
> > > > +++ b/hgext/largefiles/lfutil.py      Wed Oct 05 18:09:28 2011 +0200
> > > > @@ -104,6 +104,8 @@
> > > >  if os.name == 'nt':
> > > >      from mercurial import win32
> > > >      linkfn = win32.oslink
> > > > +else:
> > > > +    linkfn = os.link
> > > >
> > >
> > > Perhaps the function oslink from mercurial's util module should be used
> > > here.
> > >
> > > util.oslink is an alias for os.link on posix platforms and an alias for
> > > win32.oslink on the Windows platform.
> > >
> >
> > Wasn't aware of that function's existence; I'll re-submit the patch.
>
> In general, there's a bunch of compatibility cruft for old versions of
> Hg that should get stripped out here eventually.
>

The patch in question was re-sent earlier today.

Are you saying we should remove anything adding compatibility for pre-1.9?
I guess it could make sense to do this for the extension now that it is
included in Mercurial core and not installed separately along-side some
random version of Mercurial.

Cheers,
Na'Tosha



-- 
*Na'Tosha Bard*
Build & Infrastructure Developer | Unity Technologies

*E-Mail:* natosha at unity3d.com
*Skype:* natosha.bard
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20111006/cbc5638f/attachment.html>