[PATCH V2] push: propagate --new-branch and --ssh options when pushing subrepos

Angel Ezquerra angel.ezquerra at gmail.com
Fri Oct 7 00:43:40 CDT 2011


On Fri, Oct 7, 2011 at 3:58 AM, Greg Ward <greg-hg at gerg.ca> wrote:
> On Thu, Oct 6, 2011 at 5:44 PM, Angel Ezquerra <angel.ezquerra at gmail.com> wrote:
>> I am still not entirely happy with the way this works. I think it is
>> better than what we have today, because in most cases you do want to
>> allow pushing new subrepo branches. However, it is now not possible to
>> push new branches only on the parent repo... Also we have no way to
>> pass down some of the other parameters.
>>
>> A solution may be to add a flag to control whether these flags are
>> passed down to subrepos or not. However this introduces some
>> inconsistency, since the --force flag is would be passed down anyway,
>> unless we decide that is is ok to change the current mercurial
>> behavior, which is to always pass the --force flag down.
>>
>> Comments?
>
> Meh. That sounds too complex. Mercurial should do the right thing
> automatically, and there should be a really compelling reason to make
> it possible to do the wrong thing. (And you've pretty much convinced
> me that passing some subset of push options to subrepos, starting with
> --new-branch and --ssh, is the right thing to do.)

OK, then I guess the only thing left is to see if it is ok for git
subrepos to ignore these flags, since I don't really understand git
enough to modify the git.push() method to take them into account.

Angel


More information about the Mercurial-devel mailing list