[RFC] New core command: graft

Antoine Pitrou solipsis at pitrou.net
Mon Oct 10 11:09:54 CDT 2011

On Sun, 09 Oct 2011 17:23:38 -0500
Matt Mackall <mpm at selenic.com> wrote:
> Among other things, I'm looking for feedback on the UI and what features
> are critical. Right now, it copies the details of grafted changesets
> (user/date/description) verbatim. That's an ok default, but it seems
> like we'd like to be able to tweak that.

I think ability to edit the changeset message is a definite plus
(sometimes you want to mention specific problems you had when doing the
graft, or explain some differences between the two changesets).
For me "hg graft" should not commit by default, because a patch
applying fine is not enough to guarantee the result it actually ok. In
our case (CPython) we want to compile and run the test suite before
committing (at least the tests likely to be affected).

Also, I'm not sure about the date. I would say the date of grafting
makes more sense than the original changeset's. Same for the author
"hg log" should add a mention of the original changeset id when
displaying a graft changeset.

If you want another name than "hg graft", perhaps "hg port"?



More information about the Mercurial-devel mailing list