[RFC] New core command: graft

[Matt Mackall]

On Mon, 2011-10-10 at 18:09 +0200, Antoine Pitrou wrote:
> On Sun, 09 Oct 2011 17:23:38 -0500
> Matt Mackall <mpm at selenic.com> wrote:
> > 
> > Among other things, I'm looking for feedback on the UI and what features
> > are critical. Right now, it copies the details of grafted changesets
> > (user/date/description) verbatim. That's an ok default, but it seems
> > like we'd like to be able to tweak that.
> 
> I think ability to edit the changeset message is a definite plus
> (sometimes you want to mention specific problems you had when doing the
> graft, or explain some differences between the two changesets).
> For me "hg graft" should not commit by default, because a patch
> applying fine is not enough to guarantee the result it actually ok. In
> our case (CPython) we want to compile and run the test suite before
> committing (at least the tests likely to be affected).

Which gets us back to 'original author/date/description are now lost'.

> Also, I'm not sure about the date. I would say the date of grafting
> makes more sense than the original changeset's. Same for the author
> actually.
> "hg log" should add a mention of the original changeset id when
> displaying a graft changeset.

We don't have that for transplant and rebase, so I'm going to defer that
discussion until after the 2.0 release. The code freeze is this weekend.

> If you want another name than "hg graft", perhaps "hg port"?

Actually, I don't. I'm quite pleased with graft.

-- 
Mathematics is the supreme nostalgia of our time.