[PATCH 08 of 18] add function to move phase boundaries forward

Martin Geisler mg at lazybytes.net
Thu Oct 13 05:28:51 CDT 2011


timeless <timeless at gmail.com> writes:


> On 10/10/11, pierre-yves.david at logilab.fr <pierre-yves.david at logilab.fr> wrote:
>> +    if not phase.isdigit() or int(phase) not in phases.allphases:
>> +        raise util.Abort(_('unknown phase: %s' % phase),
>> +                         hint=_('use one of: %r' % phases.allphases))

> I believe _("x %s" % variable) is relatively l10n unfriendly

Yes, it's wrong and should be

  _("x %s") % variable

instead. It's mentioned here:

  http://mercurial.selenic.com/wiki/CodingStyle#Status_and_error_messages

-- 
Martin Geisler

aragost Trifork
Professional Mercurial support
http://aragost.com/mercurial/


More information about the Mercurial-devel mailing list