[PATCH 08 of 18] add function to move phase boundaries forward

Pierre-Yves David pierre-yves.david at ens-lyon.org
Thu Oct 13 17:49:40 CDT 2011


please include Alain in your comment he might be the author of what you comment on.

On 13 oct. 2011, at 12:28, Martin Geisler wrote:

> timeless <timeless at gmail.com> writes:
> 
> 
>> On 10/10/11, pierre-yves.david at logilab.fr <pierre-yves.david at logilab.fr> wrote:
>>> +    if not phase.isdigit() or int(phase) not in phases.allphases:
>>> +        raise util.Abort(_('unknown phase: %s' % phase),
>>> +                         hint=_('use one of: %r' % phases.allphases))
> 
>> I believe _("x %s" % variable) is relatively l10n unfriendly
> 
> Yes, it's wrong and should be
> 
>  _("x %s") % variable
> 
> instead. It's mentioned here:
> 
>  http://mercurial.selenic.com/wiki/CodingStyle#Status_and_error_messages
> 
> -- 
> Martin Geisler
> 
> aragost Trifork
> Professional Mercurial support
> http://aragost.com/mercurial/
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at selenic.com
> http://selenic.com/mailman/listinfo/mercurial-devel



More information about the Mercurial-devel mailing list