[PATCH V2] push: propagate --new-branch and --ssh options when pushing subrepos

Matt Mackall mpm at selenic.com
Sun Oct 16 21:20:41 CDT 2011

On Sat, 2011-10-15 at 22:28 +0200, Angel Ezquerra wrote:
> On Sat, Oct 15, 2011 at 4:06 PM, Matt Mackall <mpm at selenic.com> wrote:
> > Adding a bunch of new parameters here probably isn't the way to go. This
> > probably needs to take an opts dict instead. And we should probably
> > filter it in subrepo.py.
> Do you mean that we should pass the opts dictionary that is one of the
> arguments of the push function as is, and then simply use the relevant
> arguments on the corresponding subrepo push method?

Half right. Pass the opts dict, filter everything that's not on a
white-list out, then use it.

> > Also, we shouldn't really do this without adding the same support on the
> > pull/clone side.
> That makes sense. I'll see what I can do.
> In any case, which options do you think should be propagated down to
> subrepos, in addition to --force and --new-branch? Also, should
> subrepos that do not support a given option simply ignore it?

Start with those two; yes.

Resend after Nov 1st, please.

Mathematics is the supreme nostalgia of our time.

More information about the Mercurial-devel mailing list