[PATCH] largefiles: replace usage of tempfile.NamedTemporaryFile with tempfile.mkstemp
hao at fogcreek.com
Thu Oct 20 22:51:36 CDT 2011
On Thu, Oct 20, 2011 at 8:52 PM, Greg Ward <greg-hg at gerg.ca> wrote:
> Unnecessary blank line.
> At least on Unix, this almost certainly puts the temp file in /tmp.
> That is very unlikely to be the same filesystem as my repository,
> which means we're going to have to copy the file at the end -- cannot
> We generally don't start error messages with "error:" (unfortunately).
> Also, there's no indication of where the error happened (what file,
> what dir) or what it was (disk full? permission denied?). Please use
> the exception object!
Will do! Stand by for V2.
More information about the Mercurial-devel