[PATCH 4 of 5 REVIEW] phases: mark content pushed as public in local repo on push

Martin Geisler mg at lazybytes.net
Fri Oct 21 09:47:20 CDT 2011


Pierre-Yves David <pierre-yves.david at logilab.fr> writes:

> diff --git a/mercurial/discovery.py b/mercurial/discovery.py
> --- a/mercurial/discovery.py
> +++ b/mercurial/discovery.py
> @@ -64,30 +64,33 @@ def findcommonoutgoing(repo, other, only
>  def prepush(repo, remote, force, revs, newbranch):
>      '''Analyze the local and remote repositories and determine which
>      changesets need to be pushed to the remote. Return value depends
>      on circumstances:
>  
> -    If we are not going to push anything, return a tuple (None,
> -    outgoing) where outgoing is 0 if there are no outgoing
> -    changesets and 1 if there are, but we refuse to push them
> -    (e.g. would create new remote heads).
> +    If we are not going to push anything, return a tuple (None, outgoing,
> +    common) where outgoing is 0 if there are no outgoing changesets and 1 if
> +    there are, but we refuse to push them (e.g. would create new remote heads).
> +    common are the list of heads of the common set between local and remote.

You're clearly re-wrapping the text with the wrong line lenght here and
I think that is bad since it makes it hard to tell what is new and what
is old. As far as I can tell, only the final line is new? In that line,
"are" should be "is" since you're talking about a variable in singular.

-- 
Martin Geisler

Mercurial links: http://mercurial.ch/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20111021/830d3b32/attachment.pgp>


More information about the Mercurial-devel mailing list