[PATCH 3 of 5] largefiles: use smaller files in test script

Greg Ward greg-hg at gerg.ca
Mon Oct 24 19:20:25 CDT 2011


On Mon, Oct 24, 2011 at 11:13 AM, Carter, Eli <Eli.Carter at tektronix.com> wrote:
> I disagree with these changes.  We need to test that the memory warning message is not displayed in the first case.  Your change of filesize eliminates that check.

Oops. So this means we need *one* "hg add" of a >= 10 MB file in a
largefiles-enabled repo, right? But there's no point in adding a 23 MB
file, or in adding a >= 10 MB file in a non-largefiles repo. So I may
have trimmed too much, but I still think some of what I trimmed was a
legit target.

> Also, this changes the intent of the "Commit another file that should get automatically added as a largefile" test.  The point of that test was to test that a file is automatically added as a largefile _without_ any options on the commandline for largefiles.  That does mean a 10MB file is required to test that.

But the entire test runs with largefiles.minsize configured, so
*nothing* tests the builtin 10 MB limit. I'm pretty sure I didn't
change that -- it was already like that when I started hacking on the
test.

For the record, the intent of my patch was primarily to tweak test
runtime/space requirements, and secondarily to test minsize < 1 MB.

Greg


More information about the Mercurial-devel mailing list