[PATCH] largefiles: Use sha1sum.py since OS X has generic shasum utility

Lee Cantey lcantey at gmail.com
Tue Oct 25 12:58:05 CDT 2011


On Mon, Oct 24, 2011 at 5:35 PM, Greg Ward <greg-hg at gerg.ca> wrote:
> It looks like you just photocopied tests/md5sum.py and called it
> tests/sha1sum.py. It would be ever so much nicer to refactor, e.g.
>
>  * rename md5sum.py to hash.py
>  * make it take two args, hash algorithm and filename
>  * update existing callers in tests/
>  * make test-largefiles.t use it

Perfectly reasonable approach.  I left the names purposefully as
obvious replacements to the various commands one might use on various
platforms (shasum vs sha1sum and md5 vs. md5sum).

I'll just be happy to see the tests passing on OS X (and 2.4) again. :)

Regards,
Lee


More information about the Mercurial-devel mailing list