[PATCH] largefiles: Use sha1sum.py since OS X has generic shasum utility

Matt Mackall mpm at selenic.com
Tue Oct 25 16:31:52 CDT 2011


On Tue, 2011-10-25 at 17:28 -0400, Greg Ward wrote:
> On Tue, Oct 25, 2011 at 11:51 AM, Matt Mackall <mpm at selenic.com> wrote:
> > As far as I'm aware, we only need one hash function for tests and it
> > needn't be cryptographically strong. I'll change the largefiles test to
> > use the existing md5sum.py.
> 
> I don't like that for largefiles. It's important to to test that the
> content of .hglf/largefile is the SHA-1 hash of largefile. That is
> kinda of the core contract of the whole extension.

Well feel free to replace md5sum.py and all users after 2.0.

-- 
Mathematics is the supreme nostalgia of our time.




More information about the Mercurial-devel mailing list