[PATCH] largefiles: fixes failure from clone test with --pull

Hao Lian hao at fogcreek.com
Wed Oct 26 15:22:19 CDT 2011

On Wed, Oct 26, 2011 at 4:12 PM, Carter, Eli <Eli.Carter at tektronix.com> wrote:
> It seems that this should instead update the output.  Afterall, we're trying to test the local clone case here.
> That said, I'm not seeing this test fail here....
> Eli

I'm reproducing on Cygwin Windows. I suspected something was
conspiring to make this happen on Cygwin Windows only, so I was trying
to avoid updating the output and breaking the test on other platforms.

Here's the exact diff I get:

$ pwd

$ python run-tests.py test-largefiles.t

--- /cygdrive/c/code/hg/tests/test-largefiles.t
+++ /cygdrive/c/code/hg/tests/test-largefiles.t.err
@@ -841,11 +841,6 @@
   $ HOME="`pwd`/bob"
   $ cd bob
   $ hg clone ../alice/pubrepo pubrepo
-  requesting all changes
-  adding changesets
-  adding manifests
-  adding file changes
-  added 1 changesets with 1 changes to 1 files
   updating to branch default
   1 files updated, 0 files merged, 0 files removed, 0 files unresolved
   getting changed largefiles

ERROR: /cygdrive/c/code/hg/tests/test-largefiles.t output changed
Failed test-largefiles.t: output changed
# Ran 1 tests, 0 skipped, 1 failed.

I can withdraw this patch and open up an issue if --pull is a bad
solution; I'm not entirely sure what the underlying problem is if
others can't reproduce it.

More information about the Mercurial-devel mailing list