[PATCH] largefiles: fix symlink handling, with testcase

Greg Ward greg-hg at gerg.ca
Wed Oct 26 20:25:59 CDT 2011


On Wed, Oct 26, 2011 at 2:50 PM, Carter, Eli <Eli.Carter at tektronix.com> wrote:
> +Symlink to a large largefile should behave the same as a symlink to a normal file
> +  $ hg init largesymlink
> +  $ cd largesymlink
> +  $ dd if=/dev/zero bs=1k count=10k of=largefile 2>/dev/null

1) do you really need a separate repo for this test case? test-largefiles.t
   has a perfectly good repo that it uses many times

2) do you really need a 10 MB file to test this? As long as it's bigger than
   largefiles.minsize or --lfsize, it should test the bug.

Greg


More information about the Mercurial-devel mailing list