[PATCH] largefiles: fix argument to util.sha

Carter, Eli Eli.Carter at tektronix.com
Mon Oct 31 14:13:32 CDT 2011


The call isn't to sha(), it's to util.sha1().  The def of sha1() in util.py requires an argument.

An alternative fix would be:
def sha1(s=''):
in mercurial/util.py.
I figured fixing the caller was a smaller change.

Eli

> -----Original Message-----
> From: Matt Mackall [mailto:mpm at selenic.com]
> Sent: Monday, October 31, 2011 2:05 PM
> To: Carter, Eli
> Cc: mercurial-devel at selenic.com
> Subject: Re: [PATCH] largefiles: fix argument to util.sha
> 
> On Mon, 2011-10-31 at 09:39 -0700, Carter, Eli wrote:
> > # HG changeset patch
> > # User Eli Carter <eli.carter at tektronix.com> # Date 1320078866 18000 #
> > Branch stable # Node ID 2110cf3c05aea99bdf0cb06e1b158f60d54361f9
> > # Parent  87248de091352f746e8cd1cee01af29138c8e443
> > largefiles: fix argument to util.sha1
> > This can cause a traceback during clone of largefiles over ssh
> 
> I'd like to see that traceback, as this patch is quite mysterious.
> All relevant versions of Python seem to initialize sha() and sha('') identically.
> 
> --
> Mathematics is the supreme nostalgia of our time.
> 
> 



More information about the Mercurial-devel mailing list