[PATCH] largefiles: fix argument to util.sha

Matt Mackall mpm at selenic.com
Mon Oct 31 14:31:47 CDT 2011

On Mon, 2011-10-31 at 12:13 -0700, Carter, Eli wrote:
> The call isn't to sha(), it's to util.sha1().  The def of sha1() in util.py requires an argument.
> An alternative fix would be:
> def sha1(s=''):
> in mercurial/util.py.
> I figured fixing the caller was a smaller change.

It is a smaller change, however fixing it in util is still nearly
trivial and means we don't need to document the issue, debug any future
offenders, etc.

Mathematics is the supreme nostalgia of our time.

More information about the Mercurial-devel mailing list