[PATCH] largefiles: fix argument to util.sha

Matt Mackall mpm at selenic.com
Mon Oct 31 15:28:44 CDT 2011


On Mon, 2011-10-31 at 13:08 -0700, Carter, Eli wrote:
> > -----Original Message-----
> > From: Matt Mackall [mailto:mpm at selenic.com]
> > Sent: Monday, October 31, 2011 2:32 PM
> > To: Carter, Eli
> > Cc: mercurial-devel at selenic.com
> > Subject: RE: [PATCH] largefiles: fix argument to util.sha
> > 
> > On Mon, 2011-10-31 at 12:13 -0700, Carter, Eli wrote:
> > > The call isn't to sha(), it's to util.sha1().  The def of sha1() in util.py requires
> > an argument.
> > >
> > > An alternative fix would be:
> > > def sha1(s=''):
> > > in mercurial/util.py.
> > > I figured fixing the caller was a smaller change.
> > 
> > It is a smaller change, however fixing it in util is still nearly trivial and means
> > we don't need to document the issue, debug any future offenders, etc.
> 
> Here's a testcase that verifies the fix:

A doctest is much more appropriate for something on this scale.

-- 
Mathematics is the supreme nostalgia of our time.




More information about the Mercurial-devel mailing list