[PATCH 1 of 1] bisect: print current state of the bisection

[Yann E. MORIN]

Matt, All,

On Friday 16 September 2011 23:50:41 Matt Mackall wrote:
> On Fri, 2011-09-16 at 23:40 +0200, Yann E. MORIN wrote:
> > On Friday 16 September 2011 01:52:23 Matt Mackall wrote:
> > > On Fri, 2011-09-16 at 01:28 +0200, Yann E. MORIN wrote:
> > > > - pruned:
[--SNIP--]
> > > we might want to either have:
> > > 
> > > bisected(skip) and ancestors(bisected(good)) and descendants(bisected(bad))
> > > 
> > > or
> > > 
> > > bisected(skip) and ancestors(bisected(bad)) and descendants(bisected(good))
> > 
> > OK, you want only skipped csets that are still in the bisection range (eg.
> > skipped csets that are out-side the bisection scope get removed).
> > 
> > OK, got it.
> 
> Bah, that should all be 'or' rather than 'and'.

Did you mean: skip | ( good::bad | bad::good ) ?

If so, even 'untested' csets that are in (good::bad|bad::good) will also
be returned, which does not really match with the meaning of 'pruned'.

I'm no native english speaker, but to me 'pruned' means 'removed for a
reason'. We prune good, bad and skipped csets because we already know the
outcome for those.

I would rather wite it like that:
  ( good::bad | bad::good ) & ( skip | good | bad )

which translate to:
  - all csets in the bisection range: ( bad::good | good::bad )
and
  - all csets we know the state of

Which excludes all csets that are out-of-range, that is csets that were
skipped, but did not participate in the bisection.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'