[PATCH 2 of 4] hbisect: add functions to return a label for a cset bisection status

Matt Mackall mpm at selenic.com
Thu Sep 22 14:04:07 CDT 2011


On Thu, 2011-09-22 at 15:29 +0200, Yann E. MORIN wrote:
> On Thursday 22 September 2011 091217 Gilles Moris wrote:
> > On Thursday 22 September 2011 02:10:18 am Yann E. MORIN wrote:
> > > # HG changeset patch
> > > # User "Yann E. MORIN" <yann.morin.1998 at anciens.enib.fr>
> > > # Date 1316375970 -7200
> > > # Node ID 38490dd8eadf5c5e8b77ad2582328d6a4caf1f86
> > > # Parent  85607e1e24e03e75410739cfee8465c3520ef0cd
> > > hbisect: add functions to return a label for a cset bisection status
> > >
> > > Add two new functions that return a string containing the bisection status
> > > of the node passed in parameter:
> > >  - .label(node): return a multi-char string representing the status of node
> > >  - .shortlabel(node): return a single-char string representing the status
> > >    of node, usually the initial of the label
> > >
> > >     bisection status    .label()        .shortlabel()
> > >     ----------------------------------------------------------
> > >     good                'good'          '+'
> > >     bad                 'bad'           '-'
> > >     skipped             'skip'          's'
> > >     untested            'untested'      'u'
> > >     ignored             'ignored'       'i'
> > >     (others)            None            None
> > >
> > 
> > The list of shortlabel do not match the one returned by the shortlabel 
> > function.
> 
> Ah, yes. I'll fix that up. Thanks.
> 
> > Like Greg, I don't think we should use '+' and '-', that are too much linked 
> > to diffs. I would be more conservative than Greg and use just 'g' and 'b' 
> > respectively, which match the -g and -b command options.
> 
> That was what I started with as well, but I previously had a script that
> was printing the bisection status, and I was using +:good, -:bad, <:skipped
> (and >:current) in there, so I just reproduced what I was used to.

I agree with Gilles, but I think they should also be uppercase. Compare
status and resolve. So: G, B, S, U, I.

> But as opposed to Greg, i don't think we should use non-ascii glyphs,

Yes, that's just silly.

-- 
Mathematics is the supreme nostalgia of our time.




More information about the Mercurial-devel mailing list