[PATCH 1 of 4] hbisect: add two private revset descriptions

Yann E. MORIN yann.morin.1998 at anciens.enib.fr
Thu Sep 22 15:34:28 CDT 2011


On Thursday 22 September 2011 21:05:01 Matt Mackall wrote:
> On Thu, 2011-09-22 at 02:10 +0200, Yann E. MORIN wrote:
> > # HG changeset patch
> > # User "Yann E. MORIN" <yann.morin.1998 at anciens.enib.fr>
> > # Date 1316639690 -7200
> > # Node ID 85607e1e24e03e75410739cfee8465c3520ef0cd
> > # Parent  510184e5a09eb09be23b55bc1191c6ca77af05d5
> > hbisect: add two private revset descriptions
> > 
> > This patch adds two new revset descriptions:
> >  - goods: list the range of 'pruned' and 'good' csets
> >  - bads: ditto for bad csets
> 
> Any particular reason not to expose these to users?

I have no strong opinion either for or against exposing it.

My reasoning was:
  Is there a reason I'd like to know the goods range?
  None that I can think of...
  Let's make these private.

I will rewrite the patch to expose them to the user.

Thank you for the reviews! :-)

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'


More information about the Mercurial-devel mailing list