[RFC] kbfiles: an extension to track binary files with less wasted bandwidth

Matt Mackall mpm at selenic.com
Fri Sep 23 17:18:39 CDT 2011


On Fri, 2011-09-23 at 13:39 +0200, Na'Tosha Bard wrote:
> Hello,
> 
> 2011/9/22 Martin Geisler <mg at lazybytes.net>
> 
> > "Na'Tosha Bard" <natosha at unity3d.com> writes:
> > [...]
> >
> > I tried cloning the largefiles repo into the hgext folder in Mercurial
> > and ran
> >
> >  % pyflakes hgext/largefiles/*.py
> >  hgext/largefiles/basestore.py:15: 'shutil' imported but unused
> >  hgext/largefiles/basestore.py:17: 'error' imported but unused
> >  hgext/largefiles/basestore.py:17: 'url_' imported but unused
> >  hgext/largefiles/lfutil.py:39: redefinition of function 'dirstate_walk'
> > from line 35
> >  hgext/largefiles/localstore.py:57: undefined name 'err'
> >  hgext/largefiles/overrides.py:13: 're' imported but unused
> >  hgext/largefiles/overrides.py:28: 'proto' imported but unused
> >  hgext/largefiles/overrides.py:611: local variable 'dest' is assigned to
> > but never used
> >  hgext/largefiles/overrides.py:662: redefinition of function 'write' from
> > line 647
> >  hgext/largefiles/proto.py:7: 'shutil' imported but unused
> >  hgext/largefiles/proto.py:109: undefined name 'l'
> >  hgext/largefiles/proto.py:126: undefined name 'capabilities_orig'
> >  hgext/largefiles/proto.py:155: undefined name 'ssh_oldcallstream'
> >  hgext/largefiles/proto.py:162: undefined name 'http_oldcallstream'
> >  hgext/largefiles/remotestore.py:57: undefined name 'HTTPError'
> >  hgext/largefiles/remotestore.py:61: undefined name 'urllib2'
> >  hgext/largefiles/remotestore.py:86: local variable 'expect_hash' is
> > assigned to but never used
> >  hgext/largefiles/remotestore.py:95: undefined name 'store_path'
> >  hgext/largefiles/remotestore.py:100: undefined name 'store_path'
> >  hgext/largefiles/reposetup.py:15: 'httprepo' imported but unused
> >  hgext/largefiles/reposetup.py:34: undefined name '_'
> >  hgext/largefiles/reposetup.py:224: redefinition of unused 'node' from line
> > 15
> >
> > You should look into those errors.
> >
> 
> I will certainly look into these errors and get them fixed.  I've contacted
> FogCreek off-list about what their plan and schedule is so we can try to
> work together and get a patchbomb sent here for review.  If they don't have
> time, I will take up the big push if necessary.

At some point, I'm going to need to see patches start showing up here so
that I can review or apply them. 

> I really believe this extension is extremely important for Mercurial.

I don't think any more pitching is necessary, I'm totally on board for
including this and I think everyone else is excited about it too. It's
just down to the details of the actual implementation at this point.

But we are running out of time for 2.0. I'd like to see some code show
up on the list before Oct 1 if at all possible so that we can get all
the back and forth done by the code freeze date.

(FYI, I'm not going to merge the project DAGs by doing a pull.)

-- 
Mathematics is the supreme nostalgia of our time.




More information about the Mercurial-devel mailing list