[PATCH 2 of 2] Add tests for Largefiles Extension

Matt Mackall mpm at selenic.com
Thu Sep 29 16:43:24 CDT 2011


On Sat, 2011-09-24 at 17:44 +0200, Na'Tosha Bard wrote:
> # HG changeset patch
> # User Na'Tosha Bard <natosha at unity3d.com>
> # Date 1316878591 -7200
> # Node ID a3d92a9d56d54f3db7a7e3ad8a1f0c11be4e0d5e
> # Parent  fee6dc9ed4e6e900457aa1739d68fbbc46d00fdb
> Add tests for Largefiles Extension.

This is a bit of a disaster. Here's the diffstat:

 hgext/largefiles/tests/README                  |    4 
 hgext/largefiles/tests/common.py               |  232 ++++++++++++
 hgext/largefiles/tests/dummyssh                |   20 +
 hgext/largefiles/tests/hgtest.py               |  241 +++++++++++++
 hgext/largefiles/tests/test-add.py             |  118 ++++++
 hgext/largefiles/tests/test-add.py.out         |   38 ++
 hgext/largefiles/tests/test-addremove.py       |   32 +
 hgext/largefiles/tests/test-addremove.py.out   |   13 
 hgext/largefiles/tests/test-archive-r.t        |   33 +
 hgext/largefiles/tests/test-archive.py         |   75 ++++
 hgext/largefiles/tests/test-archive.py.out     |   19 +
 hgext/largefiles/tests/test-backout.py         |  158 ++++++++
 hgext/largefiles/tests/test-backout.py.out     |   24 +
 hgext/largefiles/tests/test-bisect.py          |  130 +++++++
 hgext/largefiles/tests/test-bisect.py.out      |   38 ++
 hgext/largefiles/tests/test-clone.py           |  214 +++++++++++
 hgext/largefiles/tests/test-clone.py.out       |   51 ++
 hgext/largefiles/tests/test-commit.py          |   62 +++
 hgext/largefiles/tests/test-commit.py.out      |   15 
 hgext/largefiles/tests/test-convert.py         |  251 +++++++++++++
 hgext/largefiles/tests/test-convert.py.out     |   27 +
 hgext/largefiles/tests/test-converttags.py     |  329 ++++++++++++++++++
 hgext/largefiles/tests/test-converttags.py.out |   37 ++
 hgext/largefiles/tests/test-copyrename.py      |  456 +++++++++++++++++++++++++
 hgext/largefiles/tests/test-copyrename.py.out  |   77 ++++
 hgext/largefiles/tests/test-edit.py            |   47 ++
 hgext/largefiles/tests/test-edit.py.out        |   21 +
 hgext/largefiles/tests/test-fetch.py           |   78 ++++
 hgext/largefiles/tests/test-fetch.py.out       |   15 
 hgext/largefiles/tests/test-forget.py          |  186 ++++++++++
 hgext/largefiles/tests/test-forget.py.out      |   52 ++
 hgext/largefiles/tests/test-lockout.t          |   91 ++++
 hgext/largefiles/tests/test-log.py             |  192 ++++++++++
 hgext/largefiles/tests/test-log.py.out         |   15 
 hgext/largefiles/tests/test-outgoing.py        |   71 +++
 hgext/largefiles/tests/test-outgoing.py.out    |   13 
 hgext/largefiles/tests/test-permissions.py     |  163 ++++++++
 hgext/largefiles/tests/test-permissions.py.out |   10 
 hgext/largefiles/tests/test-purge.py           |   37 ++
 hgext/largefiles/tests/test-purge.py.out       |   11 
 hgext/largefiles/tests/test-pushpull.py        |  390 +++++++++++++++++++++
 hgext/largefiles/tests/test-pushpull.py.out    |   75 ++++
 hgext/largefiles/tests/test-rebase.py          |  166 +++++++++
 hgext/largefiles/tests/test-rebase.py.out      |   28 +
 hgext/largefiles/tests/test-remove.py          |  161 ++++++++
 hgext/largefiles/tests/test-remove.py.out      |   51 ++
 hgext/largefiles/tests/test-reposetup.py       |   52 ++
 hgext/largefiles/tests/test-reposetup.py.out   |   15 
 hgext/largefiles/tests/test-requires.t         |  121 ++++++
 hgext/largefiles/tests/test-revert.py          |  303 ++++++++++++++++
 hgext/largefiles/tests/test-revert.py.out      |   70 +++
 hgext/largefiles/tests/test-rollback.py        |   53 ++
 hgext/largefiles/tests/test-rollback.py.out    |   20 +
 hgext/largefiles/tests/test-serve.t            |  179 +++++++++
 hgext/largefiles/tests/test-status.py          |  122 ++++++
 hgext/largefiles/tests/test-status.py.out      |   20 +
 hgext/largefiles/tests/test-subrepos.t         |   27 +
 hgext/largefiles/tests/test-summary.py         |   90 ++++
 hgext/largefiles/tests/test-summary.py.out     |   15 
 hgext/largefiles/tests/test-update.py          |  186 ++++++++++
 hgext/largefiles/tests/test-update.py.out      |   36 +
 hgext/largefiles/tests/test-verify.py          |  105 +++++
 hgext/largefiles/tests/test-verify.py.out      |   16 
 63 files changed, 5997 insertions(+)

- they're in the wrong place
- they have names that collide with the stuff in the right place
- there are lots of .py tests that ought to be .t tests
- there's a whole new framework hiding in here
- there are just way too many separate, highly redundant (and therefore
slow) tests

So I basically have to drop all of this for now.

We need to cherry-pick, port, and combine the best of these one by one
so that we have a small number of fast .t tests in tests/ that exercise
a large amount of the largefiles functionality.

On the upside, I will accept improvements to tests after the code
freeze.

-- 
Mathematics is the supreme nostalgia of our time.




More information about the Mercurial-devel mailing list