[PATCH] pylintrc: max-line-length equal to check-code.py

Matt Mackall mpm at selenic.com
Thu Apr 5 14:50:13 CDT 2012


On Wed, 2012-04-04 at 11:35 +0200, Mads Kiilerich wrote:
> On 04/04/2012 10:44 AM, Christian Ebert wrote:
> > # HG changeset patch
> > # User Christian Ebert<blacktrash at gmx.net>
> > # Date 1333528887 -7200
> > # Node ID f669ec7274e1c7ff2c5047991bc45d91a3472954
> > # Parent  1d8eab6dfe655e23d9884a6830a81e1757e50e33
> > pylintrc: max-line-length equal to check-code.py
> >
> > check-code's '.{85}' allows a maximum of 84 characters.
> 
> Yes, that is the hard limit.
> 
> But there is also
>    # warnings
>    [
>      (r'.{81}', "warning: line over 80 characters"),
> 
> It would probably be better to make the 80 a hard limit and fix the 
> failures.

It's set at 85 now because that made the number of errors reasonable to
clean up. It's probably time to ratchet it up to 84. The ideal limit is
80 (ie 79 characters per line), but that generates 32K of check-code
output.

-- 
Mathematics is the supreme nostalgia of our time.




More information about the Mercurial-devel mailing list