[PATCH 0 of 4 ] revert: add support for reverting

Angel Ezquerra angel.ezquerra at gmail.com
Tue Apr 10 17:39:03 CDT 2012


On Tue, Apr 10, 2012 at 8:02 PM, Matt Mackall <mpm at selenic.com> wrote:
> On Tue, 2012-04-10 at 00:06 +0200, Angel Ezquerra wrote:
>> On Thu, Mar 29, 2012 at 8:30 PM, Matt Mackall <mpm at selenic.com> wrote:
>> > On Thu, 2012-03-29 at 14:04 +0200, Martin Geisler wrote:
>> >> Angel Ezquerra <angel.ezquerra at gmail.com> writes:
>> >>
>> >> > The first patch refactors the revert function on the commands module,
>> >> > moving most of its code into cmdutil.revert.
>> >> >
>> >> > The second and third patches add support for reverting modified subrepos.
>> >>
>> >> Is it 100% clear that 'hg revert' means running 'hg update X' where X is
>> >> the revision listed in .hgsubstate?
>> >
>> > I think we could say 95%. If I discover the library I'm using is too new
>> > and I revert it at the top level, I probably just want my old library
>> > back, not a dirty library.
>> >
>> >> Btw, I don't think you need to edit .hgsubstate in the working copy. As
>> >> far as I know, it's not used for anything and commit rewrittes it
>> >> anyway.
>> >
>> > Indeed.
>>
>> Out of the revisions on this patch series, the first patch that
>> refactors the revert function on the commands module, moving most of
>> its code into cmdutil.revert has been pushed.
>>
>> I believe the last patch needs to be discussed further. However I
>> don't know if there is anything that I must do to improve the second
>> and third patches which add support for reverting modified subrepos.
>>
>> Is there something I must do to improve these patches?
>
> No idea.
>
> For the record, the only way my inbox is manageable is if I immediately
> drop things once any action has been taken on it. Maintaining and
> repeatedly consulting a mental prerequisites-before-further-action list
> on 100+ things in my inbox isn't feasible, so I deleted everything in
> this series once Martin asked for things to be fixed.

Ah! So that's your secret to keeping up with so much email! :-D

I'll wait for Martin to give me some feedback when he comes back from
his vacation.

Thanks,

Angel


More information about the Mercurial-devel mailing list