[PATCH 3 of 3] revset: speedup matching() by first matching fields that take less time to

Patrick Mézard patrick at mezard.eu
Sun Apr 15 03:45:11 CDT 2012

Le 15/04/12 00:35, Angel Ezquerra a écrit :
> On Sat, Apr 14, 2012 at 2:45 PM, Patrick Mézard <patrick at mezard.eu> wrote:
>> Le 14/04/12 14:05, Angel Ezquerra a écrit :
>>> On Apr 14, 2012 9:12 AM, "Patrick Mézard" <patrick at mezard.eu <mailto:patrick at mezard.eu>> wrote:
>>>> Le 14/04/12 01:42, Angel Ezquerra a écrit :
>>>>> # HG changeset patch
>>>>> # User Angel Ezquerra <angel.ezquerra at gmail.com <mailto:angel.ezquerra at gmail.com>>
>>>>> # Date 1334360463 -7200
>>>>> # Node ID 4075aa74e8398584a47f20c9b51af7e0d788dbcc
>>>>> # Parent  e735d3f86e7f96ebd78ea5080eb8f2db2220e63f
>>>>> revset: speedup matching() by first matching fields that take less time to
>>>>> match
>> [...]
>>>> Could you add tests in test-revset.t?
>>> I'll give it a try although I doubt I can send them before the code freeze, specially since I am not sure that the revset tests run on windows.
>>> I guess the need for a test its unrelated to this particular patch, isn't it?
>> It is really up to Matt not me, but probably yes since the revset is here already.
>> I am just a little sad we keep accepting new features with zero test coverage (and I know you have a valid excuse to do so but still).
> I agree. I wish it was easier to run the tests on windows. Even using
> a Linux VM is a pain for me since my personal laptop is quite old
> which makes running a VM a pain.
> Nevertheless, I could get a hold of some other, more powerful machine
> and I've added some tests. I've resent this series adding an extra
> patch to the series which adds these tests. The rest of the patches on
> the series are the same as the previous version of the series.

Great, thanks!

Patrick Mézard

More information about the Mercurial-devel mailing list