[PATCH V4] fileset: add "subrepo" fileset symbol
Matt Mackall
mpm at selenic.com
Mon Apr 16 17:35:10 CDT 2012
On Tue, 2012-04-17 at 00:19 +0200, Angel Ezquerra wrote:
> On Mon, Apr 16, 2012 at 8:25 PM, Matt Mackall <mpm at selenic.com> wrote:
> > On Sat, 2012-04-14 at 14:38 +0200, Angel Ezquerra wrote:
> >> # HG changeset patch
> >> # User Angel Ezquerra <angel.ezquerra at gmail.com>
> >> # Date 1332447135 -3600
> >> # Node ID 31202dfd3eda5b4c1ae2e07c56d23af8f7e6d48e
> >> # Parent a232a1b5ae9b0b3e9469d1567e36a6c42f6563e3
> >> fileset: add "subrepo" fileset symbol
> >
> > Queued for default, thanks. You owe us some tests, though.
>
> Thank you!
>
> As for the test, my understanding is that we should not try to make
> tests unitary, but complete, and that avoiding adding new tests that
> slow down the test suite is encouraged.
>
> Taking that into account, would it be enough to replace the existing
> subrepo revert test in test-subrepo.t:
>
> $ hg revert s
> reverting subrepo s
> reverting s/a
>
> with something like:
>
> $ hg revert "set:subrepo('glob:s*')"
That's the sort of thing, yes.
--
Mathematics is the supreme nostalgia of our time.
More information about the Mercurial-devel
mailing list