[PATCH 2 of 2 stable] convert: fix a test failure due to git change

Ross Lagerwall rosslagerwall at gmail.com
Wed Aug 1 07:13:29 CDT 2012


On 08/01/2012 01:52 PM, Patrick Mézard wrote:
> Your patches go in the right direction. I agree with Mads they should
> be folded. Adding short comments to the test to tell how you list the
> commit/blob/tag objects (command line call is fine) would help us
> maintaining the whole thing without having to deal with git internal
> details.

OK.
> 
> I suggest we converge on your patchset first, and once it is ready I
> would try to refactor convert/git.py to use subprocess directly so
> the redirection works correctly.
> 
In general for convert/git.py, should stderr be redirected or should it
go through to the terminal? Currently, stderr from git leaks through to
the user for most of the commands.

-- 
Ross Lagerwall

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 294 bytes
Desc: OpenPGP digital signature
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20120801/0d0a3d5e/attachment.pgp>


More information about the Mercurial-devel mailing list