[PATCH 2 of 2 stable] convert: fix a test failure due to git change

[Patrick Mézard]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Le 01/08/12 14:13, Ross Lagerwall a écrit :
> On 08/01/2012 01:52 PM, Patrick Mézard wrote:
>> Your patches go in the right direction. I agree with Mads they should
>> be folded. Adding short comments to the test to tell how you list the
>> commit/blob/tag objects (command line call is fine) would help us
>> maintaining the whole thing without having to deal with git internal
>> details.
> 
> OK.
>>
>> I suggest we converge on your patchset first, and once it is ready I
>> would try to refactor convert/git.py to use subprocess directly so
>> the redirection works correctly.
>>
> In general for convert/git.py, should stderr be redirected or should it
> go through to the terminal? Currently, stderr from git leaks through to
> the user for most of the commands.

It leaks on Unix and is silently removed on Windows, go figure.

I do not really know, both versions can be defended. Being a bug fix, I would stick with what is done when possible, that is what you did here, redirecting only when you need the error output.

- --
Patrick Mézard

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJQGR/8AAoJEBaMCOeEaaNYdO4P/jVviISuyjtPaSCBkkcaJps1
5AFQ2K+btUziXsSSpxrAmK4B/wjZXR5HvOcgabBIu5A8RS9UC5KxWP/qo5hxBbL9
RrwyeIZ6Zf6DrqSodImrd0JOQm6IKhnyHRHoLf3VaC0ra87lyCcR13TfQgt2Buwp
b9JZWMO8kvI5mzDcTbx6TEvclDKxQsfb2pivFvUx0Y0b8akYcWD6ut5dik4lUlmJ
lNhy8w7ldBJP7/FdE+Pk3ywgqawEO5m8H2E/dwKQ9sHKPGciifFuDaa0KAZSrKNf
BAhDsPZcYOnptwiTvKWELUoihvswgUYRQr4bUTsbTFSIJ0kvF7D0B33u2jVkOffa
x8E/c5bs3/a9F+uY0y2CXnfewaZFTWQLDhk4F9en6Ylar1b/LLGRRqnDvxgNBYBy
Hphv+ZZ4rWKb6WcorgiKKgWQkN4f+Tn1rycOCGs9FmI69wv8JU3FFqU2vhDcFf2n
dTx3R41xJyfVEjG6X64jt0CbzKBTnW7PEFnqBgnEA2FNcDfE1GwIEC0ySu2DeY3W
BfMSZLs1ztl8gqlKfruStZeTnxYFwF05ikv97fZgz8JrU8p97syaIZQJy9zW2W1X
zKINFrYax+VFbo0kIjsLp+9DxSQFf91oMgkpaYihMEcRReuZQzWVqTQYCTRgbTJJ
HKxjIhr7Ca0XmyWC03YF
=w5vT
-----END PGP SIGNATURE-----