[PATCH 2 of 2 stable] convert: fix a test failure due to git change
patrick at mezard.eu
Wed Aug 1 07:24:28 CDT 2012
-----BEGIN PGP SIGNED MESSAGE-----
Le 01/08/12 14:13, Ross Lagerwall a écrit :
> On 08/01/2012 01:52 PM, Patrick Mézard wrote:
>> Your patches go in the right direction. I agree with Mads they should
>> be folded. Adding short comments to the test to tell how you list the
>> commit/blob/tag objects (command line call is fine) would help us
>> maintaining the whole thing without having to deal with git internal
>> I suggest we converge on your patchset first, and once it is ready I
>> would try to refactor convert/git.py to use subprocess directly so
>> the redirection works correctly.
> In general for convert/git.py, should stderr be redirected or should it
> go through to the terminal? Currently, stderr from git leaks through to
> the user for most of the commands.
It leaks on Unix and is silently removed on Windows, go figure.
I do not really know, both versions can be defended. Being a bug fix, I would stick with what is done when possible, that is what you did here, redirecting only when you need the error output.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
-----END PGP SIGNATURE-----
More information about the Mercurial-devel