[PATCH 3 of 3 stable] check-code: fix check for trailing whitespace on continued lines too

Mads Kiilerich mads at kiilerich.com
Wed Aug 8 18:39:43 CDT 2012


Patrick Mézard wrote, On 08/08/2012 09:25 PM:
> Le 08/08/12 18:11, Mads Kiilerich a écrit :
>> # HG changeset patch
>> # User Mads Kiilerich <mads at kiilerich.com>
>> # Date 1344442237 -7200
>> # Branch stable
>> # Node ID 2644fe9d4e82629b938b4c28ad63eac4fdc853a5
>> # Parent  689793034d8fca445b8371b5b3ab995a038965f8
>> check-code: fix check for trailing whitespace on continued lines too
>
> --- /Users/pmezard/dev/hg/hg-dev/tests/test-check-code-hg.t
> +++ /Users/pmezard/dev/hg/hg-dev/tests/test-check-code-hg.t.err
> @@ -6,6 +6,10 @@
>     >     exit 80
>     > fi
>     $ hg manifest | xargs "$check_code" || echo 'FAILURE IS NOT AN OPTION!!!'
> +  tests/test-import-git.t:330:
> +   >   > +++ b/foo bar	
> +   trailing whitespace on non-output
> +  FAILURE IS NOT AN OPTION!!!
>   
>     $ hg manifest | xargs "$check_code" --warnings --nolineno --per-file=0 || true
>     hgext/convert/cvsps.py:0:
>
>
> And the test is described by:
>
>    Filenames with spaces:
>
> So I guess dropping the trailing TAB is not an option either. Can we make check-code ignore this line?

Thanks. I was in a rush and didn't test my last changes enough.

With 471f30d360ea already in stable I pushed it to crew default.

/Mads



More information about the Mercurial-devel mailing list