[PATCH stable-v2] convert: fix a test failure due to git change (issue3428)

Bryan O'Sullivan bos at serpentine.com
Mon Aug 13 10:29:33 CDT 2012


On Fri, Aug 3, 2012 at 10:20 AM, Patrick Mézard <patrick at mezard.eu> wrote:

> What the util abstractions have are sane default values for subprocess
> parameters. Things like close_fds, bufsize, shell, etc. But
> subprocess.Popen is a better API than os.popen, maybe we should really wrap
> it in util, only rewriting the default values.
>

FWIW, the internals of subprocess are both ugly and, under many Python
versions, quite buggy. It's also quite slow. So be careful in your
enthusiasm for it :-)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20120813/9316c20a/attachment.html>


More information about the Mercurial-devel mailing list