[PATCH] notify: support revset selection for subscriptions

[Angel Ezquerra]

On Aug 14, 2012 7:34 AM, "Michał Sznajder" <michalsznajder at gmail.com> wrote:
>
> Back to the list.
>
> On Mon, Aug 13, 2012 at 11:37 PM, Angel Ezquerra <ezquerra at gmail.com>
wrote:
> >
> > On Aug 13, 2012 11:12 PM, <michalsznajder at gmail.com> wrote:
> >>
> >> # HG changeset patch
> >> # User Michal Sznajder <michalsznajder at gmail.com>
> >> # Date 1344890530 -7200
> >> # Node ID 8c8aa7d83db0b1fd0d1062b79fe3768c032d29fb
> >> # Parent  c6f88e7f95b764e23b7e0b4353c5a6458bbc3cc4
> >> notify: support revset selection for subscriptions
> >>
> >> A repo pattern for any notify configuration contains a glob matching
the
> >> path to the repo. Additionally, it may now contain a revset spec,
> >> separated
> >> from the glob by '#'.
> >
> > isn't it a bit weird to use the "comment" character as the separator?
> >
> > What about using "?" as in CGI URLs?
>
> It was already agreed between Matt and David that # is better in [1]
> and I actually like this.
>
> On second thought: do you think it is going to break some parsers?
>
> [1] http://www.selenic.com/pipermail/mercurial-devel/2012-June/041086.html
>
> Michal Sznajder

Ok, I had missed that discussion. As I said I find it a bit weird but it
seems it has already been decided.

I don't know if some parsers may have problems with this. Is that important
as long as mercurial handles it properly? In any case, the fact that the
#symbol is located on the key part, rather than on the value part probably
helps.

Angel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20120814/f386617b/attachment.html>