[PATCH] notify: support revset selection for subscriptions

[David Champion]

* On 14 Aug 2012, Michał Sznajder wrote: 
> Back to the list.
> 
> On Mon, Aug 13, 2012 at 11:37 PM, Angel Ezquerra <ezquerra at gmail.com> wrote:
> >
> > On Aug 13, 2012 11:12 PM, <michalsznajder at gmail.com> wrote:
> >>
> >> # HG changeset patch
> >> # User Michal Sznajder <michalsznajder at gmail.com>
> >> # Date 1344890530 -7200
> >> # Node ID 8c8aa7d83db0b1fd0d1062b79fe3768c032d29fb
> >> # Parent  c6f88e7f95b764e23b7e0b4353c5a6458bbc3cc4
> >> notify: support revset selection for subscriptions
> >>
> >> A repo pattern for any notify configuration contains a glob matching the
> >> path to the repo. Additionally, it may now contain a revset spec,
> >> separated
> >> from the glob by '#'.
> >
> > isn't it a bit weird to use the "comment" character as the separator?
> >
> > What about using "?" as in CGI URLs?
> 
> It was already agreed between Matt and David that # is better in [1]
> and I actually like this.

I'm -0 on it personally, but Matt prefers it to introducing a new
syntax.  It's a reasonable position, so I'm not eager to argue it.

Michał, thanks for picking this up.  Unfortunately I had completely
forgotten it among a horde of other things on my table.

> On second thought: do you think it is going to break some parsers?

It's only Mercurial itself that will parse this, right?  Or, at least,
it's a file that is defined as Mercurial's asset, so it may declare
the syntax?

I think that comments in the ini file match r'^\s*#'.

-- 
David Champion • dgc at uchicago.edu • IT Services • University of Chicago