[PATCH 2 of 2] fix wording and not-completely-trivial spelling errors and bad docstrings

[Mads Kiilerich]

On 15/08/12 03:23, Augie Fackler wrote:
> On Aug 14, 2012, at 7:22 PM, Mads Kiilerich wrote:
>
>> # HG changeset patch
>> # User Mads Kiilerich <mads at kiilerich.com>
>> # Date 1344989263 -7200
>> # Node ID 7677b03e2c73e67455712f38653388b4f8f8fcc3
>> # Parent  c271e69d350f7a6812a763f3bb66e6e5b91d38ad
>> fix wording and not-completely-trivial spelling errors and bad docstrings
>>
>> diff --git a/hgext/convert/monotone.py b/hgext/convert/monotone.py
>> --- a/hgext/convert/monotone.py
>> +++ b/hgext/convert/monotone.py
>> @@ -225,7 +225,6 @@
>>              return [self.rev]
>>
>>      def getchanges(self, rev):
>> -        #revision = self.mtncmd("get_revision %s" % rev).split("\n\n")
> Can we have "deleted dead code" as a discrete change?

Yes ... but this is all about minor fixes to comments. The original 
reviewer apparently didn't care and it is questionable whether they are 
worth fixing at all so I don't want to make too much noise and work out 
of it ;-)

But ok, it could be done in separate changes that proves and explains 
why the changes are safe.

>>              # caching against the next repo.status call
>>              mm, aa, dd = repo.status(patchparent, top)[:3]
>>              changes = repo.changelog.read(top)
>> diff --git a/hgext/record.py b/hgext/record.py
>> --- a/hgext/record.py
>> +++ b/hgext/record.py
>> @@ -33,7 +33,7 @@
>>      - ('file',    [header_lines + fromfile + tofile])
>>      - ('context', [context_lines])
>>      - ('hunk',    [hunk_lines])
>> -    - ('range',   (-start,len, +start,len, diffp))
>> +    - ('range',   (-start,len, +start,len, proc))
> I have no idea what diffp or proc should mean.

Neither did I. But the value ends up in a variable called 'proc' so now 
it is slightly more consistent. (It seems like renaming to something 
like 'context' or 'function name' would be more descriptive ... but that 
is a different task.)

>>          'relglob:<glob>' - an unrooted glob (*.c matches C files in all dirs)
>>          'relpath:<path>' - a path relative to cwd
>>          'relre:<regexp>' - a regexp that needn't match the start of a name
>> diff --git a/mercurial/obsolete.py b/mercurial/obsolete.py
>> --- a/mercurial/obsolete.py
>> +++ b/mercurial/obsolete.py
>> @@ -55,10 +55,6 @@
>> from mercurial import util, base85
>> from i18n import _
>>
>> -# the obsolete feature is not mature enought to be enabled by default.
>> -# you have to rely on third party extension extension to enable this.
>> -_enabled = False
>> -
> Sorry, what the heck?

That chunk appeared twice.

>
>> diff --git a/mercurial/setdiscovery.py b/mercurial/setdiscovery.py
>> --- a/mercurial/setdiscovery.py
>> +++ b/mercurial/setdiscovery.py
>> @@ -84,9 +84,6 @@
>>                      abortwhenunrelated=True):
>>      '''Return a tuple (common, anyincoming, remoteheads) used to identify
>>      missing nodes from or in remote.
>> -
>> -    shortcutlocal determines whether we try use direct access to localrepo if
>> -    remote is actually local.
> Also here.

There is no such parameter and this chunk really doesn't make sense ... 
AFAICS.

Thanks for the comments.

/Mads