[PATCH 1 of 2] fix spelling errors
Mads Kiilerich
mads at kiilerich.com
Wed Aug 15 05:30:00 CDT 2012
On 15/08/12 03:28, Augie Fackler wrote:
>
> On Aug 14, 2012, at 7:22 PM, Mads Kiilerich wrote:
>
>> --- a/mercurial/httpclient/__init__.py
>
>
> Don't patch anything in httpclient - it'll regress next time stuff
> comes in from upstream.
We can't have 'forbidden areas' in our code. But I guess the guy taking
new stuff from upstream knows how to merge instead of making code dumps ;-)
>
> If you're comfortable signing the Google CLA, feel encouraged to send
> me a set of patches for that project.
I doubt trivial spelling fixes can be copyrighted at all, so just take
it and use it in any way you like.
> Otherwise I'll try to get to this on my own (if you could share your
> methodology, I'd appreciate that.)
Yes, I will do that. Now I'm testing whether the result makes sense.
I use some huge whitelists that should be reviewed.
I don't know if spell checking is suitable for the test suite. I guess
different versions of aspell and dictionaries will give different results.
Checking commit messages could perhaps catch some stupid errors too ...
but I'm not sure how that should work, what it should check and how
badly it should fail.
/Mads
More information about the Mercurial-devel
mailing list