[PATCH 3 of 3] killdaemons: read pids from file arguments if any
Mads Kiilerich
mads at kiilerich.com
Mon Aug 20 06:01:36 CDT 2012
On 20/08/12 08:38, Patrick Mézard wrote:
> Le 20/08/12 00:39, Mads Kiilerich a écrit :
>> Patrick Mezard wrote, On 08/19/2012 09:22 PM:
>>> On Windows, MinGW kill implementation does not seem to use system
>>> process identifiers, and systematically fails when called in tests.
>>> killdaemons.py could be a suitable replacement.
>>>
>
>>> - Convert all kill utility calls to killdaemons.py calls
>>> - Add a rule in check-code.py to forbid kill calls
>> 'kill' is in some places used to kill sub processes where the pid come from $!. Shouldn't 'kill' still be used in these cases?
> It would be replaced with:
>
> $ echo $! > stuff.pid
> $ killdaemons.py stuff.pid
Do $! and kill use different kinds of 'system process identifiers' ...
and do $! and killdaemons use the same kind?
> I can grep only one instance of this in test-static.http.t.
There is also test-hup.t and test-convert-p4*.t
/Mads
More information about the Mercurial-devel
mailing list