[PATCH] fix for convert extension issue3469

[Lawrence Stewart]

On 08/20/12 20:43, Mads Kiilerich wrote:
> On 20/08/12 12:01, Laurens Holst wrote:
>> Op 20-08-12 08:48, Lawrence Stewart schreef:
>>> I can see from [1] that setting "Content-Disposition: inline" seems
>>> to have done the trick (as compared to my original email at [2]), so
>>> I'm going to declare victory against Thunderbird's convoluted means
>>> for controlling attachment inlining (which, for reference, requires
>>> you to go into the Thunderbid config editor and change
>>> mail.content_disposition_type to 0).
>>
>> Nope it didn’t do the trick; when I reply to your mail, it does not
>> quote the patch. The reason for inlining patches as opposed to
>> attaching (with or without content-disposition inline) is that it is
>> more convenient to write review comments.

Not sure why your client wouldn't quote the patch inline in your reply, 
but ok, I give up on making Thunderbird behave. Sorry for the noise.

> Compare also with the options of 'hg email':
>
> http://www.selenic.com/pipermail/mercurial-devel/2012-May/040639.html
> was sent like 'email --attach' ("send patches as attachments")
>
> http://www.selenic.com/pipermail/mercurial-devel/2012-August/043632.html
> was sent like 'email --inline' ("send patches as inline attachments")
>
> We prefer like 'email --body' ("send patches as inline message text
> (default)")

ACK. I hope my next email in a sec will DTRT.

Cheers,
Lawrence