[PATCH 5 of 6] bookmarks: extract valid destination logic in a dedicated function

Adrian Buehlmann adrian at cadifra.com
Fri Aug 24 10:42:23 CDT 2012


On 2012-08-24 17:14, pierre-yves.david at logilab.fr wrote:
> # HG changeset patch
> # User Pierre-Yves David <pierre-yves.david at logilab.fr>
> # Date 1343842849 -7200
> # Node ID bb4f46cc1c046702a735ae9ab352302d48614f03
> # Parent  79d63ffb7f1ff5daca6fcea74848b7ac729ee357
> bookmarks: extract valid destination logic in a dedicated function
                                             into a
> 
> We usually update bookmarks only if the new location is descendant of the one.
                                                                        ~~~~~~~
                                                                        ?? (grammar parsing error)
> We extract this logic in a function.This is the first step to allow more
                        into a function. This ..
> complexe logic based using obsolescence in this decision.
  complex              (on?) using..

                ( I don't really get what that sentence means... [in *what* decision?] )
> 
> The previous code were not wrappable. I do not expect anything outside mercurial
                    was

                ( what is meant by "wrappable"? When is code "wrappable"? )

> to break because of this change.


More information about the Mercurial-devel mailing list