[PATCH] record: use in-memory patching for recording changes (fixes #3591)

Augie Fackler raf at durin42.com
Mon Aug 27 22:30:25 CDT 2012


On Aug 27, 2012, at 4:56 PM, Bryan O'Sullivan wrote:

> On Mon, Aug 27, 2012 at 12:29 PM, <michalsznajder at gmail.com> wrote:
> 
>> record: use in-memory patching for recording changes (fixes #3591)
>> 
> 
> Thanks for working on this!
> 
> 
>> Notes on changes:
>> - test-record.t passes without one small tests (when someone breaks patch
>>  while editing it - i'll try to fix it later)
>> 
> 
> That would be good. There's also some whitespace at the ends of lines in
> your patch.
> 
> 
>> - patch.filestore(): do we want to get rid of it and do everything in
>> memeory? how?
>> 
> 
> Continuing to use filestore seems fine for now.


In fact, with stupidly large working copies, it seems like we'd always want to have an on-disk fallback.

> 
> 
>> - repo.setparents(newrev): is this good way to update to given revison?
>> 
> 
> No, use hg.update instead.

Hm. I'm not sure that's right - we don't want to merge with the wc state, just set the parents?

> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at selenic.com
> http://selenic.com/mailman/listinfo/mercurial-devel



More information about the Mercurial-devel mailing list