[PATCH] remove template-vars.txt - it is outdated and neither usable nor necessary

Mads Kiilerich mads at kiilerich.com
Wed Aug 29 18:49:55 CDT 2012


Matt Mackall wrote, On 08/29/2012 10:12 PM:
> I spot 7 failures to conform to ContributingCode in the top 10 commit 
> summaries on this page: 
> http://hg.intevation.org/mercurial/crew/graph/573e80049cad

In 'hg log -u mpm -l 20' I spot 16 failures to conform to the 
'subsystem:' part of ContributingChanges. They are all that way for a 
good reason: There is no 'subsystem' for these changes.

I spot no explanation on ContributingChanges of what 'subsystem' should 
be for commits that don't touch a specific subsystem - and shouldn't be 
mentioned in WhatsNew.

As far as I know the primary reason for 'subsystem:' is to help your 
private script sorting and filtering when creating WhatsNew. I would 
guess that it is counter productive to get important changes that need 
announcement mixed up with internal and minor changes that don't deserve 
to be mentioned.

Please clarify on ContributingChanges what you would like to see. 
Perhaps by declaring a 'meta', 'internal' or 'refactor' 'subsystem'. It 
would also be helpful to clarify 'cmdutil' vs 'commit' and 'tests' vs 
'test-foo.t'.

/Mads


More information about the Mercurial-devel mailing list