[PATCH] hgweb: add RSS and Atom subscribe buttons to the main paper template pages

[Angel Ezquerra]

On Tue, Dec 4, 2012 at 9:32 AM, Matt Mackall <mpm at selenic.com> wrote:
> On Tue, 2012-12-04 at 00:41 +0100, Angel Ezquerra wrote:
>> # HG changeset patch
>> # User Angel Ezquerra <angel.ezquerra at gmail.com>
>> # Date 1354578089 -3600
>> # Node ID 62f1adcd73969f967098c08000ca50f129bcfd59
>> # Parent  41d3a5a1c8495cd599e5b422fddcdf93609b8101
>> hgweb: add RSS and Atom subscribe buttons to the main paper template pages
>>
>> The buttons are found at the bottom of each page. They are similar to the
>> monoblue template buttons, but their colors have been changed to better match
>> the patper black, grey and white color palette of the paper style.
>
> Three things I would do differently:
>
> a) use the standard icon (ie from feedicons.com)
> b) link to only the Atom feed
> c) put the icon under the menu on the left
>
> Once upon a time it made sense to offer two types of feeds: when clients
> might only have RSS support, but you had content that would actually
> work better with Atom.
>
> But every client has supported atom feeds for years now (anyone have a
> counterexample?), so we should simply use it. We're syndicating HTML, so
> Atom is technically more suited. Also, Atom is an IETF standard rather
> than.. well, go read about RSS versions. Adding two links to paper that
> basically do the same thing is just clutter. (Alternately, if people
> REALLY think there's a problem with Atom, then we should just advertise
> the RSS feeds.)
>
> If at some point we switch the other styles over to use the icon, we
> should just use one icon there as well. The old RSS subscriptions should
> continue to work, of course.

I think this is a good idea. Actually I also thought that having 2
buttons is a little uncommon, since most pages only show a single
"feed button". However  I decided to follow the example of the
existing buttons on the monoblue theme since I did not know which feed
is the best of the two.

Would it make sense to add a config option that let you choose which
type of feed you want to advertise on this new, single button (the
default would be atom as you suggest)?

The only issue I see with using the atom feed by default is that I
could not get the atom-branches feed (which I added on the other patch
I sent to the list yesterday) to work. If anyone can help me with that
it would be awesome.

Cheers,

Angel