[PATCH V2] dirstate: test normalize is truthy instead of using a no-op lambda

Kevin Bullock kbullock+mercurial at ringworld.org
Tue Dec 4 14:32:49 CST 2012


On 4 Dec 2012, at 12:29 PM, Siddharth Agarwal wrote:

> # HG changeset patch
> # User Siddharth Agarwal <sid0 at fb.com>
> # Date 1354645758 28800
> # Node ID 6688ba567bcd57d05e8867ba3c3560d38dafbac4
> # Parent  11191f1c3d088cc8af01afda410a47928e551683
> dirstate: test normalize is truthy instead of using a no-op lambda
> 
> hg perfstatus -u on a working directory with 170,000 files, without this
> change:
> ! wall 1.869404 comb 1.850000 user 1.170000 sys 0.680000 (best of 6)
> 
> With this change:
> ! wall 1.839561 comb 1.830000 user 1.120000 sys 0.710000 (best of 6)

I don't have a big enough repo handy to stress-test this on, but on smallish repos it certainly doesn't harm performance (Mac OS X here). LGTM.

pacem in terris / мир / शान्ति / ‎‫سَلاَم‬ / 平和
Kevin R. Bullock



More information about the Mercurial-devel mailing list