[PATCH] largefiles: Commit directories that only contain largefiles (issue3548)

Kevin Bullock kbullock+mercurial at ringworld.org
Mon Dec 10 12:20:54 CST 2012


On Dec 10, 2012, at 8:01 AM, Levi Bard wrote:

> # HG changeset patch
> # User Levi Bard <levi at unity3d.com>
> # Date 1355147922 -3600
> # Node ID fcf5fda9138ea94bce52a03c7af618904b50f16c
> # Parent  40374059d227850ec2f5fb4f21a1b619136e2a6a
> largefiles: Commit directories that only contain largefiles (issue3548)
> 
> If we pass a directory to commit whose only commitable files
> are largefiles, the core commit code aborts before finding
> the largefiles.
> So we do the following:
> For directories that only have largefiles as matches,
> we explicitly add the largefiles to the matchlist and remove
> the directory.
> In other cases, we leave the match list unmodified.

Oof, the wrapping here makes my eyes burn. Whitespace and bullets (asterisks or hyphens) are your friends. :)

Also, the first sentence of the long description isn't clear if it's describing the state before or after this patch.

Code looks superficially good, but I'm willfully unfamiliar with the largefiles code.

> diff -r 40374059d227 -r fcf5fda9138e tests/test-largefiles.t
> --- a/tests/test-largefiles.t	Tue Nov 27 22:24:02 2012 +0100
> +++ b/tests/test-largefiles.t	Mon Dec 10 14:58:42 2012 +0100
> @@ -345,6 +345,59 @@
>   A sub2/large6
>   A sub2/large7
> 
> +Committing directories containing only large files.

+1 for adding a test without adding an `hg init`.

pacem in terris / мир / शान्ति / ‎‫سَلاَم‬ / 平和
Kevin R. Bullock



More information about the Mercurial-devel mailing list