[PATCH 06 of 15] speedy: custom wire protocol

Tomasz Kłeczek tomasz.kleczek at gmail.com
Thu Dec 13 01:23:36 CST 2012


I thought that adding such mechanisms at this point would be an overkill..


On Wed, Dec 12, 2012 at 7:30 PM, Augie Fackler <raf at durin42.com> wrote:

>
> On Dec 11, 2012, at 12:38 PM, Tomasz Kleczek <tkleczek at fb.com> wrote:
>
> > +        else:
> > +            raise TypeError("wireprotocol deserialization: unknown "
> > +                    "value type descriptor: %r")
>
> You've got a few weird indentations in this patch like this.
>
> I'm also a /little/ weirded out by the lack of a version (or capability)
> handshake in the protocol, but perhaps it fits within YAGNI.
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at selenic.com
> http://selenic.com/mailman/listinfo/mercurial-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20121212/1dde807b/attachment.html>


More information about the Mercurial-devel mailing list